Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask Ceph RBD adminSecrets in logs when logLevel >= 4 #95245

Merged
merged 1 commit into from Oct 6, 2020
Merged

Mask Ceph RBD adminSecrets in logs when logLevel >= 4 #95245

merged 1 commit into from Oct 6, 2020

Conversation

sfowl
Copy link
Contributor

@sfowl sfowl commented Oct 2, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
credentials/secrets should not be exposed in logs, even at high logging levels

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Considered removing "key <masked" entirely from log messages, but thought that made it unclear whether a key was used or not.

Does this PR introduce a user-facing change?:

Masks ceph RBD adminSecrets in logs when logLevel >= 4

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @sfowl!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @sfowl. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 2, 2020
@rootfs
Copy link
Contributor

rootfs commented Oct 2, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 2, 2020
@sjenning
Copy link
Contributor

sjenning commented Oct 2, 2020

/lgtm
/assign @jsafrane

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2020
@sfowl
Copy link
Contributor Author

sfowl commented Oct 5, 2020

/retest

@jsafrane
Copy link
Member

jsafrane commented Oct 6, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, sfowl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@sfowl
Copy link
Contributor Author

sfowl commented Oct 6, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5e5ff88 into kubernetes:master Oct 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 6, 2020
@sfowl sfowl mentioned this pull request Oct 6, 2020
Merged
This was referenced Oct 6, 2020
Merged
Merged
@cpanato
Copy link
Member

cpanato commented Oct 8, 2020

/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 8, 2020
k8s-ci-robot added a commit that referenced this pull request Oct 8, 2020
@k8s-ci-robot
Merge pull request #95330 from sfowl/automated-cherry-pick-of-#95245-…
744dec9 
…upstream-release-1.17

Automated cherry pick of #95245: Mask Ceph RBD adminSecrets in logs when logLevel >= 4
k8s-ci-robot added a commit that referenced this pull request Oct 8, 2020
@k8s-ci-robot
Merge pull request #95327 from sfowl/automated-cherry-pick-of-#95245-…
5e3fac6 
…upstream-release-1.19

Automated cherry pick of #95245: Mask Ceph RBD adminSecrets in logs when logLevel >= 4
k8s-ci-robot added a commit that referenced this pull request Oct 8, 2020
@k8s-ci-robot
Merge pull request #95329 from sfowl/automated-cherry-pick-of-#95245-…
92bf8a2 
…upstream-release-1.18

Automated cherry pick of #95245: Mask Ceph RBD adminSecrets in logs when logLevel >= 4
This was referenced Oct 13, 2020
Merged
Merged
@sfowl sfowl mentioned this pull request Oct 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane Awaiting requested review from jsafrane

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@sjenning sjenning

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sfowl @k8s-ci-robot @rootfs @sjenning @jsafrane @cpanato